Add E2E triage test case for not-affected resolution (RHEL-174694)#556
Add E2E triage test case for not-affected resolution (RHEL-174694)#556TomasTomecek wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the end-to-end triage agent tests to support the NOT_AFFECTED resolution. It introduces a new test case using NotAffectedData and restructures the assertions in test_triage_agent to be resolution-specific. Feedback suggests strengthening the assertions for the NOT_AFFECTED resolution by verifying the data type is NotAffectedData and ensuring justification_category is present.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| elif expected_output.resolution == Resolution.NOT_AFFECTED: | ||
| # TODO: validate justification_category against a known set of values | ||
| assert real_output.data.explanation |
There was a problem hiding this comment.
To ensure robust validation of the NOT_AFFECTED resolution, we should explicitly verify that real_output.data is an instance of NotAffectedData (preventing Pydantic union coercion issues) and assert that justification_category is populated and non-empty, as it is a required metadata field for Red Hat's triage process.
| elif expected_output.resolution == Resolution.NOT_AFFECTED: | |
| # TODO: validate justification_category against a known set of values | |
| assert real_output.data.explanation | |
| elif expected_output.resolution == Resolution.NOT_AFFECTED: | |
| assert isinstance(real_output.data, NotAffectedData) | |
| assert real_output.data.explanation | |
| assert real_output.data.justification_category |
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com> Assisted-by: Claude
1 participant
Summary
not-affectedresolution — the first test case for this resolution typepackageandfix_versionare only checked for resolution types that have them (BACKPORT, REBASE), sinceNotAffectedDatahas a different schemaCorresponding test fixture data (mock Jira + mock repo config) added to the testing-jiras repo.
Test plan
make run-triage-agent-e2e-testslocally — RHEL-174694 test case passes🤖 Generated with Claude Code